<html>
<head><meta charset="utf-8"><title>coercions benchmark · t-compiler/wg-nll · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/index.html">t-compiler/wg-nll</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/coercions.20benchmark.html">coercions benchmark</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="127900306"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/coercions%20benchmark/near/127900306" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/coercions.20benchmark.html#127900306">(Jun 11 2018 at 13:51)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> I've re-enabled coercions, and it appears to be even worse than inflate currently: <a href="https://perf.rust-lang.org/nll-dashboard.html" target="_blank" title="https://perf.rust-lang.org/nll-dashboard.html">https://perf.rust-lang.org/nll-dashboard.html</a> is showing 2,200% (0.8 seconds to 16 seconds)</p>



<a name="127900352"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/coercions%20benchmark/near/127900352" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/coercions.20benchmark.html#127900352">(Jun 11 2018 at 13:52)</a>:</h4>
<p>ok :)</p>



<a name="127900354"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/coercions%20benchmark/near/127900354" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/coercions.20benchmark.html#127900354">(Jun 11 2018 at 13:52)</a>:</h4>
<p>thanks</p>



<a name="127900364"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/coercions%20benchmark/near/127900364" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/coercions.20benchmark.html#127900364">(Jun 11 2018 at 13:52)</a>:</h4>
<p>that is indeed ungreat!</p>



<a name="127900432"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/coercions%20benchmark/near/127900432" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/coercions.20benchmark.html#127900432">(Jun 11 2018 at 13:54)</a>:</h4>
<p>huh, weird. I had <code>git bisect</code> running on <a href="https://github.com/rust-lang/rust/pull/51460" target="_blank" title="https://github.com/rust-lang/rust/pull/51460">https://github.com/rust-lang/rust/pull/51460</a> — and it claims that the first bad commit is the one that removes the <code>#[inline(never)]</code> annotations...</p>



<a name="127900434"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/coercions%20benchmark/near/127900434" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/coercions.20benchmark.html#127900434">(Jun 11 2018 at 13:54)</a>:</h4>
<p>/me finds that hard to believe</p>



<a name="127900520"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/coercions%20benchmark/near/127900520" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/coercions.20benchmark.html#127900520">(Jun 11 2018 at 13:56)</a>:</h4>
<p>must have done something wrong with the script :)</p>



<a name="127900596"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/coercions%20benchmark/near/127900596" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/coercions.20benchmark.html#127900596">(Jun 11 2018 at 13:58)</a>:</h4>
<p>Might have inverted good/bad, so maybe check the commit before it manually?</p>



<a name="127900815"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/coercions%20benchmark/near/127900815" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/coercions.20benchmark.html#127900815">(Jun 11 2018 at 14:02)</a>:</h4>
<p>I think it was beacuse my script failed to run <code>cargo clean -p futures</code> in between steps =)</p>



<a name="127900821"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/coercions%20benchmark/near/127900821" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/coercions.20benchmark.html#127900821">(Jun 11 2018 at 14:03)</a>:</h4>
<p>I'm on a plane, so debugging this stuff (over ssh) is painfully slow</p>



<a name="127900844"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/coercions%20benchmark/near/127900844" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/coercions.20benchmark.html#127900844">(Jun 11 2018 at 14:03)</a>:</h4>
<p>but I'll try to start another bisect run...</p>



<a name="127900909"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/coercions%20benchmark/near/127900909" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/coercions.20benchmark.html#127900909">(Jun 11 2018 at 14:05)</a>:</h4>
<p>on the plus side, the results oughta be ready by the time I land ;)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>